feat(KV): Add methods to get list of kv stores #1270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MATILLAT Quentin <[email protected]>
|
As this is not part of the KV ADR it would need to accepted by the maintainers first. Will get back here after its discussed. |
|
Hey. We agreed that this is a good idea. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose 2 methods (
key_value_store_namesandkey_value_stores) based on the existingstreams&stream_names.I added the option on
stream&stream_namesto filter the subject, but as apub(crate)only. Maybe we should expose this publicly, but I don't know what the best API would be (stream_filteredor aStream::subjectlikePurge::filter).